-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information page cms 179 test rebase 2 #28
Draft
sanjeevz3009
wants to merge
45
commits into
main
Choose a base branch
from
information-page-CMS-179-test-rebase-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate for testing
…nformation page tweaked
…hortened and migration file regenerated
…d to reflect the InformationPage model changes
…ired to be entered by the user
* Add the Contact Details snippet https://jira.ons.gov.uk/browse/CMS-80 * Add a basic table block * Add the release calendar app with models * Programmatically create the release calendar index * Add the basic templates * Add a base form class for easier validation * Add icons to the various panels * Add validation logic * Update templates * Add tests * Expand core tests * Expand coverage configuration adds a few extra files to the ignore. and explicitly filters the RemovedInDjango60Warning * Tidy up based on code review * Prevent release calendar page deletion through the UI * Move the changes to the release date below contact details e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023 * Fail if under 90% test coverage
* Comment out the scheduler image * Remove scheduler from Procfile
* Add skeleton models for Theme / Topic pages * Add base analysis series and page models * Use a custom icon for the contact detail snippet * Update the StreamField block template to pass the block ID to its children * Set parent/subpage types for the new page models * Wire in the analysis page template * Add series functionality (latest/previous releases) * Add tests and fail if coverage under 90% * Tidy up based on code review * Make the accredited / census blocks separate includes * Include changes to release dates when status is confirmed * Allow setting the release date when switching to confirmed * Only allow release date or text, not both * Prevent release calendar page deletion through the UI * Move the changes to the release date below contact details e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023 * Switch to using a StreamField for the release page related links * Disable the "too-few-public-methods" pylint check globally * Make the equation/ONS embed check reusable
sanjeevz3009
force-pushed
the
information-page-CMS-179-test-rebase-2
branch
from
November 15, 2024 18:44
af079e7
to
0a339c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Describe what you have changed and why, link to other PRs or Issues as appropriate.
How to review
Describe the steps required to test the changes (include screenshots if appropriate).
Follow-up Actions
List any follow-up actions (if applicable), like needed documentation updates or additional testing.